Code review comment for lp:~hazmat/pyjuju/repository-broken-charms

Reviewers: mp+98062_code.launchpad.net,

Message:
Please take a look.

Description:
Charm local repositories should always process all their charms for a
search.

Changes

   - add catch all handler to repository for unexpected errors (os)
   - rearrange charm exception hierarchy
     - charmnotfound is not a charm structural error
     - metadata errors are charm errors.

https://code.launchpad.net/~hazmat/juju/repository-broken-charms/+merge/98062

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5841056/

Affected files:
   A [revision details]
   M juju/charm/errors.py
   M juju/charm/repository.py
   M juju/charm/tests/test_errors.py
   M juju/charm/tests/test_repository.py