Code review comment for lp:~hazmat/pyjuju/local-respect-series

Revision history for this message
Jim Baker (jimbaker) wrote :

+1, looks good to me. The only thing I found problematic was this signature:

=== modified file 'juju/lib/lxc/__init__.py'
--- juju/lib/lxc/__init__.py 2011-10-04 23:38:52 +0000
+++ juju/lib/lxc/__init__.py 2012-02-03 00:27:50 +0000
@@ -154,7 +154,8 @@
                  customize_script=None,
                  debug_log=None,
                  console_log=None,
- customize_log=None):
+ customize_log=None,
+ series="oneiric"):

But according to the earlier comments, you are planning to make this arg required for non-tests anyway.

review: Approve

« Back to merge proposal