Code review comment for lp:~hazmat/pyjuju/local-respect-series

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Excerpts from Kapil Thangavelu's message of Wed Jan 25 18:31:29 UTC 2012:
> Kapil Thangavelu has proposed merging lp:~hazmat/juju/local-respect-series into lp:juju.
>
> Requested reviews:
> juju hackers (juju)
> Related bugs:
> Bug #914392 in juju: "LXC local provider does not respect 'series' (only installs oneiric)"
> https://bugs.launchpad.net/juju/+bug/914392
>
> For more details, see:
> https://code.launchpad.net/~hazmat/juju/local-respect-series/+merge/90182
>
> Modify local provider to respect the environment's default-series
>
> Fixes issues with creating precise containers.

I'm a little nervous about the fact that some functions have "oneiric"
and some "precise" as defaults.

It seems like it would be safer to *always* require the user to specify,
or at the very least, take this from the environment default-series.

« Back to merge proposal