Code review comment for lp:~hazmat/pyjuju/local-network
Revision history for this message
| Kapil Thangavelu (hazmat) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Excerpts from Benjamin Saller's message of Fri Sep 16 21:11:25 UTC 2011:
> Review: Approve
>
> The code in this branch looks fine. As we've talked about my issue is that we don't need to do all the heavy lifting that this branch currently does. Currently libvirt-bin does much/all of the networking setup and doing this by hand isn't really needed.
>
> That said the code here may enable easier changes and better control in the future. So +1 with that reservations.
Thanks. just to be clear this code defers all the heavy lifting to libvirt, its
just provides an abstraction over managing/inspecting libvirt networking
features from ensemble.. err juju ;-) I agree this is currently doing more than we
need as we're relying on the libvirt default network for the lxc provider,
instead of creating our own.