[0]
+ networks[name] = (state == "active") and True or False
Isn't that equivalent to:
+ networks[name] = (state == "active")
?
[1]
Nice tests; s/nonexistant/nonexistent/.
[2]
+def start_network(name, subnet):
I feel this function could be rearranged a little for clarity.
[3]
FAILED (skips=5, failures=3, errors=92, successes=1346)
Many due to "'FileStorage' object has no attribute 'get_url'", as noted in https://code.launchpad.net/~hazmat/ensemble/lib-files/+merge/73444, but it doesn't look like that's all of them.
« Back to merge proposal
[0]
+ networks[name] = (state == "active") and True or False
Isn't that equivalent to:
+ networks[name] = (state == "active")
?
[1]
Nice tests; s/nonexistant/ nonexistent/ .
[2]
+def start_network(name, subnet):
I feel this function could be rearranged a little for clarity.
[3]
FAILED (skips=5, failures=3, errors=92, successes=1346)
Many due to "'FileStorage' object has no attribute 'get_url'", as noted in https:/ /code.launchpad .net/~hazmat/ ensemble/ lib-files/ +merge/ 73444, but it doesn't look like that's all of them.