Code review comment for lp:~hazmat/pyjuju/lib-files

Excerpts from William Reade's message of Thu Sep 01 08:58:22 UTC 2011:
> Review: Needs Fixing
> [0]
>
> get_url is missing, and is needed for download_formula.
>
> I'm not sure whether it should return a file:// url (which download_formula does in fact undertand) because I'm not sure whether we intend local dev machines to have access to the whole filesystem; I'd suggest that they probably shouldn't, really... and so, if that's the case, we'll presumably need to run some sort of file server of our own. Thoughts?

Thanks for having a look at this.

[0]
Addressed the get_url missing and some other test assumptions.

The machine agent will be running in the host creating lxc containers, and needs
to do so as root. The formulas are specifically downloaded into /formulas on the
container rootfs by the machine agent. ie. using local disk is a very good fit
imo, its the simplest thing that works, and has low overhead. Additional
commonality between separate provider implementations, shouldn't come at the
expense of that.

cheers,

kapil