Code review comment for lp:~hazmat/pyjuju/fast-yaml

Revision history for this message
Jim Baker (jimbaker) wrote :

+1, LGTM, nice speedup and a clean transition to the C extensions. Just
need to take care of the two trivials where CSafeLoader/CSafeDumper is
used instead of the equivalent juju.lib.serializer wrappers.

https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py
File juju/environment/config.py (right):

https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py#newcode178
juju/environment/config.py:178: config = yaml.load(content,
Loader=yaml.CSafeLoader)
Use juju.lib.serializer.load instead

https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py#newcode313
juju/environment/config.py:313: return yaml.dump(config,
Dumper=yaml.CSafeDumper)
Use juju.lib.serializer.dump instead

https://codereview.appspot.com/6493100/

« Back to merge proposal