+1, LGTM, nice speedup and a clean transition to the C extensions. Just need to take care of the two trivials where CSafeLoader/CSafeDumper is used instead of the equivalent juju.lib.serializer wrappers.
https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py File juju/environment/config.py (right):
https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py#newcode178 juju/environment/config.py:178: config = yaml.load(content, Loader=yaml.CSafeLoader) Use juju.lib.serializer.load instead
https://codereview.appspot.com/6493100/diff/5002/juju/environment/config.py#newcode313 juju/environment/config.py:313: return yaml.dump(config, Dumper=yaml.CSafeDumper) Use juju.lib.serializer.dump instead
https://codereview.appspot.com/6493100/
« Back to merge proposal
+1, LGTM, nice speedup and a clean transition to the C extensions. Just CSafeDumper is
need to take care of the two trivials where CSafeLoader/
used instead of the equivalent juju.lib.serializer wrappers.
https:/ /codereview. appspot. com/6493100/ diff/5002/ juju/environmen t/config. py t/config. py (right):
File juju/environmen
https:/ /codereview. appspot. com/6493100/ diff/5002/ juju/environmen t/config. py#newcode178 t/config. py:178: config = yaml.load(content, yaml.CSafeLoade r) serializer. load instead
juju/environmen
Loader=
Use juju.lib.
https:/ /codereview. appspot. com/6493100/ diff/5002/ juju/environmen t/config. py#newcode313 t/config. py:313: return yaml.dump(config, yaml.CSafeDumpe r) serializer. dump instead
juju/environmen
Dumper=
Use juju.lib.
https:/ /codereview. appspot. com/6493100/