Code review comment for lp:~hazmat/pyjuju/fast-yaml

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Reviewers: mp+123470_code.launchpad.net,

Message:
Please take a look.

Description:
ensure use of py yaml c extension for speed.

Backwards compatible. Drops test time in half. Should improve speed
across the board, things like status will see marked improvements.

https://code.launchpad.net/~hazmat/juju/fast-yaml/+merge/123470

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6493100/

Affected files:
   A [revision details]
   M juju/agents/tests/test_unit.py
   M juju/charm/config.py
   M juju/charm/metadata.py
   M juju/charm/tests/test_base.py
   M juju/charm/tests/test_bundle.py
   M juju/charm/tests/test_config.py
   M juju/charm/tests/test_directory.py
   M juju/charm/tests/test_metadata.py
   M juju/charm/tests/test_publisher.py
   M juju/control/config_set.py
   M juju/control/constraints_get.py
   M juju/control/deploy.py
   M juju/control/initialize.py
   M juju/control/status.py
   M juju/control/tests/test_add_unit.py
   M juju/control/tests/test_bootstrap.py
   M juju/control/tests/test_config_get.py
   M juju/control/tests/test_config_set.py
   M juju/control/tests/test_constraints_get.py
   M juju/control/tests/test_deploy.py
   M juju/control/tests/test_destroy_environment.py
   M juju/control/tests/test_expose.py
   M juju/control/tests/test_initialize.py
   M juju/control/tests/test_open_tunnel.py
   M juju/control/tests/test_remove_relation.py
   M juju/control/tests/test_scp.py
   M juju/control/tests/test_status.py
   M juju/control/tests/test_unexpose.py
   M juju/control/tests/test_upgrade_charm.py
   M juju/control/tests/test_utils.py
   M juju/environment/config.py
   M juju/environment/tests/test_config.py
   M juju/hooks/protocol.py
   M juju/hooks/scheduler.py
   M juju/hooks/tests/test_cli.py
   M juju/hooks/tests/test_invoker.py
   M juju/hooks/tests/test_scheduler.py
   M juju/lib/format.py
   A juju/lib/serializer.py
   M juju/providers/common/cloudinit.py
   M juju/providers/common/state.py
   M juju/providers/common/tests/test_cloudinit.py
   M juju/providers/common/tests/test_findzookeepers.py
   M juju/providers/common/tests/test_state.py
   M juju/providers/common/tests/test_utils.py
   M juju/providers/common/utils.py
   M juju/providers/ec2/tests/common.py
   M juju/providers/ec2/tests/test_bootstrap.py
   M juju/providers/ec2/tests/test_findzookeeper.py
   M juju/providers/ec2/tests/test_launch.py
   M juju/providers/ec2/tests/test_provider.py
   M juju/providers/ec2/tests/test_state.py
   M juju/providers/local/files.py
   M juju/providers/local/tests/test_agent.py
   M juju/providers/local/tests/test_container.py
   M juju/providers/local/tests/test_files.py
   M juju/providers/openstack/tests/test_bootstrap.py
   M juju/providers/openstack/tests/test_launch.py
   M juju/providers/openstack/tests/test_state.py
   M juju/providers/orchestra/tests/common.py
   M juju/providers/orchestra/tests/test_bootstrap.py
   M juju/providers/orchestra/tests/test_findzookeepers.py
   M juju/providers/orchestra/tests/test_state.py
   M juju/state/charm.py
   M juju/state/environment.py
   M juju/state/hook.py
   M juju/state/machine.py
   M juju/state/relation.py
   M juju/state/security.py
   M juju/state/service.py
   M juju/state/tests/test_charm.py
   M juju/state/tests/test_environment.py
   M juju/state/tests/test_hook.py
   M juju/state/tests/test_machine.py
   M juju/state/tests/test_relation.py
   M juju/state/tests/test_security.py
   M juju/state/tests/test_service.py
   M juju/state/tests/test_topology.py
   M juju/state/tests/test_utils.py
   M juju/state/topology.py
   M juju/state/utils.py
   M juju/unit/lifecycle.py
   M juju/unit/tests/test_lifecycle.py
   M juju/unit/tests/test_workflow.py
   M juju/unit/workflow.py

« Back to merge proposal