Code review comment for lp:~hazmat/pyjuju/env-id

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

On Tue, Jan 15, 2013 at 9:34 AM, Kapil Thangavelu <
<email address hidden>> wrote:

> On 2013/01/15 14:42:47, bcsaller wrote:
> > LGTM. It will be worth adding a note to the hook docs that this env
> var is
> > present but that can happen later if you want. Given that this will
> have to be
> > ported to juju-core making a note about its availability is nice.
>
> > Also I suspect there will be changes in rapi branches to include the
> env uuid
> > either via a new call or as part of the connect message header.
>
>
> thanks for the review. docs and rapi are in different branches so need
> to be tackled separately. i fired off an email to juju-dev re the
> functionality.
>
>
per core comments switching this to JUJU_ENV_UUID.

cheers,

Kapil

« Back to merge proposal