Code review comment for lp:~hazmat/pyjuju/ensemble-resolved

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

This looks great, +1! Only one nit related to terminology:

[7]

+ # Verify the relations are in need of resolution.
+ resolve_relations = {}
(...)
+ # Mark the relations for resolution.
+ yield unit_state.set_relation_resolved(resolve_relations)

There's some terminology conflict here, in the spirit we debated in the IRC channel regarding the pre-requisite branch.

E.g.:

s/are in need of resolution/are not running/
s/resolve_relations/resolved_relations/
s/for resolution/as resolved/

review: Approve

« Back to merge proposal