Code review comment for lp:~hazmat/pyjuju/cli-placement-restore

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Alright, so here is a review to try to get to some agreement:

[1]

Let's have the renamed the option to a boolean called

    --temporary-local-hack

With the following help message:

    help="Temporary placement hack for testing juju."

[2]

Let's not change the provider interface, or introduce pick_policy,
etc. The provider interface we have today looks nice and is going
into the direction we want.

Instead, we do something as simple as this:

    placement = provider.get_placement_policy()
    if options.temporary_local_hack:
        placement = "local"

[3]

Once we sort out making our system stable for 12.04, let's come back
and do placement correctly. It's definitely something that should be
high in our priority list.

review: Needs Fixing

« Back to merge proposal