juju-core

Merge lp:~hazmat/juju-core/manual-bash-user into lp:~go-bot/juju-core/trunk

  1. manual-bash-user
  2. Merge into trunk
Proposed by Kapil Thangavelu
Status: Merged
Approved by: Kapil Thangavelu
Approved revision: no longer in the source branch.
Merged at revision: 2663
Proposed branch: lp:~hazmat/juju-core/manual-bash-user
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
environs/manual/init.go (+1/-1)
To merge this branch: bzr merge lp:~hazmat/juju-core/manual-bash-user
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+216746@code.launchpad.net

Commit message

manual provider shell for created ubuntu user is bash

Description of the change

shell for created ubuntu user is bash

normalize shell when manual provider is creating ubuntu user to be bash.

https://codereview.appspot.com/90160045/

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Reviewers: mp+216746_code.launchpad.net,

Message:
Please take a look.

Description:
shell for created ubuntu user is bash

normalize shell when manual provider is creating ubuntu user to be bash.

https://code.launchpad.net/~hazmat/juju-core/manual-bash-user/+merge/216746

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/90160045/

Affected files (+3, -1 lines):
   A [revision details]
   M environs/manual/init.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20140421110750-ijhvsrnn2fb1hhq2
+New revision: <email address hidden>

Index: environs/manual/init.go
=== modified file 'environs/manual/init.go'
--- environs/manual/init.go 2014-03-18 23:44:18 +0000
+++ environs/manual/init.go 2014-04-22 13:53:50 +0000
@@ -176,7 +176,7 @@

  const initUbuntuScript = `
  set -e
-(id ubuntu &> /dev/null) || useradd -m ubuntu
+(id ubuntu &> /dev/null) || useradd -m ubuntu -s /bin/bash
  umask 0077
  temp=$(mktemp)
  echo 'ubuntu ALL=(ALL) NOPASSWD:ALL' > $temp

Revision history for this message
Andrew Wilkins (axwalk) wrote :

On 2014/04/22 15:12:44, hazmat wrote:
> Please take a look.

LGTM

https://codereview.appspot.com/90160045/

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

thanks. just noticed you had proposed the same. doh.

On Tue, Apr 22, 2014 at 9:19 AM, <email address hidden> wrote:

> On 2014/04/22 15:12:44, hazmat wrote:
>
>> Please take a look.
>>
>
> LGTM
>
> https://codereview.appspot.com/90160045/
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'environs/manual/init.go'
2--- environs/manual/init.go 2014-03-18 23:44:18 +0000
3+++ environs/manual/init.go 2014-04-22 15:12:24 +0000
4@@ -176,7 +176,7 @@
5
6 const initUbuntuScript = `
7 set -e
8-(id ubuntu &> /dev/null) || useradd -m ubuntu
9+(id ubuntu &> /dev/null) || useradd -m ubuntu -s /bin/bash
10 umask 0077
11 temp=$(mktemp)
12 echo 'ubuntu ALL=(ALL) NOPASSWD:ALL' > $temp

Subscribers

People subscribed via source and target branches

to status/vote changes: