juju-gui

Code review comment for lp:~hatch/juju-gui/parse-pending-types

  1. parse-pending-types
  2. Merge into trunk
Revision history for this message
Madison Scott-Clary (makyo) wrote :

LGTM, QA okay, one question, feel free to say no! Thanks.

https://codereview.appspot.com/36240043/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/36240043/diff/1/app/models/models.js#newcode205
app/models/models.js:205: if (life === ALIVE || life === 'dying') {
We have a constant ALIVE, might it make sense to do he samefor DYING?

https://codereview.appspot.com/36240043/

« Back to merge proposal