LGTM with trivials and sandbox QA good. waiting on QA on ec2.
https://codereview.appspot.com/33130043/diff/20001/app/models/models.js File app/models/models.js (right):
https://codereview.appspot.com/33130043/diff/20001/app/models/models.js#newcode591 app/models/models.js:591: @return {Array} An array of the aggregate map and relation errors Thank you for improving names and docs. Nice.
https://codereview.appspot.com/33130043/diff/20001/app/models/models.js#newcode614 app/models/models.js:614: if (farService) { this code fixes peer relation issues?
https://codereview.appspot.com/33130043/diff/20001/test/test_model.js File test/test_model.js (right):
https://codereview.appspot.com/33130043/diff/20001/test/test_model.js#newcode136 test/test_model.js:136: id: 'wordpress/2', On 2013/11/26 20:42:45, jeff.pihach wrote: > The order of these is important to make sure that the first unit error, if it's > a relation error gets caught properly (bug from first rev)
In that case could you elaborate in a code comment what's going on? All I see in the code is "one of these has a relation error and one has an install error," not something subtle about ordering.
https://codereview.appspot.com/33130043/
« Back to merge proposal
LGTM with trivials and sandbox QA good. waiting on QA on ec2.
https:/ /codereview. appspot. com/33130043/ diff/20001/ app/models/ models. js models. js (right):
File app/models/
https:/ /codereview. appspot. com/33130043/ diff/20001/ app/models/ models. js#newcode591 models. js:591: @return {Array} An array of the aggregate map
app/models/
and relation errors
Thank you for improving names and docs. Nice.
https:/ /codereview. appspot. com/33130043/ diff/20001/ app/models/ models. js#newcode614 models. js:614: if (farService) {
app/models/
this code fixes peer relation issues?
https:/ /codereview. appspot. com/33130043/ diff/20001/ test/test_ model.js
File test/test_model.js (right):
https:/ /codereview. appspot. com/33130043/ diff/20001/ test/test_ model.js# newcode136 model.js: 136: id: 'wordpress/2',
test/test_
On 2013/11/26 20:42:45, jeff.pihach wrote:
> The order of these is important to make sure that the first unit
error, if it's
> a relation error gets caught properly (bug from first rev)
In that case could you elaborate in a code comment what's going on? All
I see in the code is "one of these has a relation error and one has an
install error," not something subtle about ordering.
https:/ /codereview. appspot. com/33130043/