Code review comment for lp:~hatch/juju-gui/inspector-relation-status

Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+196770_code.launchpad.net,

Message:
Please take a look.

Description:
Adds relation status to inspector relation panel

The overall relation status is now indicated on the inspector relation
panel using the same icons as the unit status. If any unit has a
relation
error the entire relation is shown as in error.

To QA:
Sandbox:
Deploy Mysql & Wordpress with 50 units each
Relate them
See the inspector relations panel, there should be a green icon
Wait for a relation error
See the inspector relations panel, there should be a red icon
Reduce the units on your inspector to 1
See the inspector relations panel, there should be a green icon
   because it's very likely the unit in error is gone

LXC
Deploy two instances of failtester
set ones relation fail setting to true
relate them
the inspector relations panel should show an error
resolve the error
the inspector relations panel should show green

https://code.launchpad.net/~hatch/juju-gui/inspector-relation-status/+merge/196770

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/33130043/

Affected files (+77, -82 lines):
   A [revision details]
   M app/models/models.js
   M app/templates/service-relations-list.handlebars
   M app/templates/service-relations-viewlet.handlebars
   D app/templates/service-relations.handlebars
   M app/views/utils.js
   M app/views/viewlets/service-relations.js
   M lib/views/juju-inspector.less
   M test/test_model.js

« Back to merge proposal