Merge lp:~hatch/juju-gui/cookie-z-index into lp:juju-gui/experimental

Proposed by Jeff Pihach
Status: Merged
Merged at revision: 1174
Proposed branch: lp:~hatch/juju-gui/cookie-z-index
Merge into: lp:juju-gui/experimental
Diff against target: 19 lines (+2/-2)
1 file modified
lib/views/cookies.less (+2/-2)
To merge this branch: bzr merge lp:~hatch/juju-gui/cookie-z-index
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+193491@code.launchpad.net

Description of the change

Fixes the z-index for the cookie warning.

https://codereview.appspot.com/20430043/

To post a comment you must log in.
Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+193491_code.launchpad.net,

Message:
Please take a look.

Description:
Fixes the z-index for the cookie warning.

https://code.launchpad.net/~hatch/juju-gui/cookie-z-index/+merge/193491

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/20430043/

Affected files (+4, -2 lines):
   A [revision details]
   M lib/views/cookies.less

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/views/cookies.less
=== modified file 'lib/views/cookies.less'
--- lib/views/cookies.less 2013-07-24 15:34:08 +0000
+++ lib/views/cookies.less 2013-10-31 20:19:58 +0000
@@ -1,5 +1,5 @@
  .cookie-policy {
- z-index: 100;
+ z-index: 602;
      position: fixed;
      bottom: 0;
      width: 100%;
@@ -14,7 +14,7 @@
      -webkit-box-sizing: border-box;
      box-sizing: border-box;
      background: none;
- margin: 0 auto;
+ margin: 10px auto;
      position: relative;
      text-align: left;
      width: 984px;

Revision history for this message
Jeff Pihach (hatch) wrote :

*** Submitted:

Fixes the z-index for the cookie warning.

R=
CC=
https://codereview.appspot.com/20430043

https://codereview.appspot.com/20430043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/views/cookies.less'
2--- lib/views/cookies.less 2013-07-24 15:34:08 +0000
3+++ lib/views/cookies.less 2013-10-31 20:23:30 +0000
4@@ -1,5 +1,5 @@
5 .cookie-policy {
6- z-index: 100;
7+ z-index: 602;
8 position: fixed;
9 bottom: 0;
10 width: 100%;
11@@ -14,7 +14,7 @@
12 -webkit-box-sizing: border-box;
13 box-sizing: border-box;
14 background: none;
15- margin: 0 auto;
16+ margin: 10px auto;
17 position: relative;
18 text-align: left;
19 width: 984px;

Subscribers

People subscribed via source and target branches