Small test change requested, and otherwise code is LGTM. doing qa now.
https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js File test/test_bundle_details_view.js (right):
https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js#newcode188 test/test_bundle_details_view.js:188: 'gui-y': '' I wonder if we should not allow this either. shrug.
https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js#newcode208 test/test_bundle_details_view.js:208: view._positionAnnotationsIncluded = function() { But this way you are not testing whether _postionAnnotationsIncluded actually ever can approve something! :-) Can we just adjust the data instead?
https://codereview.appspot.com/14502061/
« Back to merge proposal
Small test change requested, and otherwise code is LGTM. doing qa now.
https:/ /codereview. appspot. com/14502061/ diff/1/ test/test_ bundle_ details_ view.js bundle_ details_ view.js (right):
File test/test_
https:/ /codereview. appspot. com/14502061/ diff/1/ test/test_ bundle_ details_ view.js# newcode188 bundle_ details_ view.js: 188: 'gui-y': ''
test/test_
I wonder if we should not allow this either. shrug.
https:/ /codereview. appspot. com/14502061/ diff/1/ test/test_ bundle_ details_ view.js# newcode208 bundle_ details_ view.js: 208: view._positionA nnotationsInclu ded ionsIncluded
test/test_
= function() {
But this way you are not testing whether _postionAnnotat
actually ever can approve something! :-) Can we just adjust the data
instead?
https:/ /codereview. appspot. com/14502061/