Code review comment for lp:~hatch/juju-gui/bundle-fail-gracefully

Revision history for this message
Gary Poster (gary) wrote :

Small test change requested, and otherwise code is LGTM. doing qa now.

https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js
File test/test_bundle_details_view.js (right):

https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js#newcode188
test/test_bundle_details_view.js:188: 'gui-y': ''
I wonder if we should not allow this either. shrug.

https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js#newcode208
test/test_bundle_details_view.js:208: view._positionAnnotationsIncluded
= function() {
But this way you are not testing whether _postionAnnotationsIncluded
actually ever can approve something! :-) Can we just adjust the data
instead?

https://codereview.appspot.com/14502061/

« Back to merge proposal