Code review comment for lp:~hatch/juju-gui/bundle-fail-gracefully

Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+190769_code.launchpad.net,

Message:
Please take a look.

Description:
Bundle topology rendering fails gracefully

If the bundle does not provide proper xy position annotations
on any of the services in its deployer file we do not render
the bundle topology and instead issue a warning.

Because we don't have any bundles with proper positions right
now I added the flag strictBundle to enable this feature.

https://code.launchpad.net/~hatch/juju-gui/bundle-fail-gracefully/+merge/190769

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14502061/

Affected files (+119, -23 lines):
   A [revision details]
   M app/subapps/browser/views/bundle.js
   M test/test_bundle_details_view.js

« Back to merge proposal