Code review comment for lp:~hatch/juju-gui/auth-routes

Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+163732_code.launchpad.net,

Message:
Please take a look.

Description:
Converted login/logout to use routes

Login/Logout is now controlled via the routing system
this caused a number of issues with the order of
operations for the auth system so I would love
another QA using all three back ends please.

https://code.launchpad.net/~hatch/juju-gui/auth-routes/+merge/163732

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9415043/

Affected files:
   A [revision details]
   M app/app.js
   M app/config-debug.js
   M app/index.html
   M app/store/env/go.js
   M app/store/env/python.js
   M test/index.html
   M test/test_app.js
   M test/test_app_hotkeys.js
   M test/test_endpoints.js
   M test/test_env_go.js
   M test/test_notifications.js

« Back to merge proposal