Code review comment for lp:~hasselmm/appmenu-gtk/gtk3

Revision history for this message
Mathias Hasselmann (hasselmm) wrote :

> 1) Do we really need --with-gtk3? Seems like --with-gtk2 is enough.

Dropped.

> 2) You need to add the following in src/bridge.c:

Fixed.

> Unfortunately (and this is my fault), the headers use different directories
> for gtk2/gtk3.

Maybe still can be fixed somehow? The files in that folders seem to be identical.

« Back to merge proposal