Merge lp:~hartmut-php/maria/5.5-wl820 into lp:~atcurtis/maria/5.5-wl820
Proposed by
Hartmut Holzgraefe
Status: | Merged |
---|---|
Approved by: | Antony T Curtis |
Approved revision: | 3405 |
Merged at revision: | 3405 |
Proposed branch: | lp:~hartmut-php/maria/5.5-wl820 |
Merge into: | lp:~atcurtis/maria/5.5-wl820 |
Diff against target: |
30 lines (+5/-4) 2 files modified
plugin/perl_udf/CMakeLists.txt (+1/-0) plugin/perl_udf/perl_udf.xs (+4/-4) |
To merge this branch: | bzr merge lp:~hartmut-php/maria/5.5-wl820 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Antony T Curtis | Approve | ||
Review via email:
|
Description of the change
fix for out-of-source CMake builds ... perl_udf.cc is creted in the build dir while perl_init.h is in the source dir, so an extra include path needs to be set for this ...
To post a comment you must log in.
Please consider adding the following somewhere (maria could benefit from the my_getopt.c patch):
=== modified file 'mysql- test/mysql- test-run. pl' mysql-test- run.pl 2012-07-03 18:50:12 +0000 mysql-test- run.pl 2012-08-24 18:51:03 +0000 _plugin=
mtr_file_ exists( vs_config_ dirs('plugin/ example_ udf', 'psm_example.dll'), plugins/ psm_example. so",
"$basedir/ plugin/ example_ udf/psm_ example. so",
"$path_ plugin_ libdir/ psm_example. so"); 'PSMEXAMPLE_ PLUGIN' }= plugin=
mtr_file_ exists( vs_config_ dirs('plugin/ java_udf' , 'psm_java.dll'), plugins/ psm_java. so",
"$basedir/ plugin/ java_udf/ psm_java. so",
"$path_ plugin_ libdir/ psm_java. so"); 'PSMJAVA_ PLUGIN' }= plugin=
mtr_file_ exists( vs_config_ dirs('plugin/ perl_udf' , 'psm_perl.dll'), plugins/ psm_perl. so",
"$basedir/ plugin/ perl_udf/ psm_perl. so",
"$path_ plugin_ libdir/ psm_perl. so"); 'PSMPERL_ PLUGIN' }=
--- mysql-test/
+++ mysql-test/
@@ -2382,6 +2382,7 @@
if ($mysql_version_id >= 50100) {
my $lib_psmexample
+ "$opt_vardir/
$ENV{
@@ -2396,6 +2397,7 @@
if ($mysql_version_id >= 50100) {
my $lib_psmjava_
+ "$opt_vardir/
$ENV{
@@ -2411,6 +2413,7 @@
if ($mysql_version_id >= 50100) {
my $lib_psmperl_
+ "$opt_vardir/
$ENV{
=== modified file 'mysys/my_getopt.c' &my_charset_ latin1, cur_arg[0])) is_args_ separator( cur_arg) ))
is_cmdline_ arg= 1;
--- mysys/my_getopt.c 2012-01-13 14:50:02 +0000
+++ mysys/my_getopt.c 2012-08-24 18:44:06 +0000
@@ -193,6 +193,14 @@
char **first= pos;
char *cur_arg= *pos;
opt_found= 0;
+ while (cur_arg[0] && my_isspace(
+ cur_arg++;
+ if (!cur_arg[0])
+ {
+ /* consume empty arguments */
+ (*argc)--;
+ continue;
+ }
if (!is_cmdline_arg && (my_getopt_
{