Merge lp:~harmw/cloud-init/freebsd-fixes into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Harm Weites
Status: Merged
Merged at revision: 1006
Proposed branch: lp:~harmw/cloud-init/freebsd-fixes
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 34 lines (+2/-4)
2 files modified
cloudinit/distros/freebsd.py (+1/-4)
tools/build-on-freebsd (+1/-0)
To merge this branch: bzr merge lp:~harmw/cloud-init/freebsd-fixes
Reviewer Review Type Date Requested Status
Scott Moser Pending
Review via email: mp+233247@code.launchpad.net

Description of the change

Use the regular logic to create sudo rules and just supply the correct filename. The temp script in tools/ should install 2 more dependencies, so make it do that.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cloudinit/distros/freebsd.py'
--- cloudinit/distros/freebsd.py 2014-08-28 17:54:00 +0000
+++ cloudinit/distros/freebsd.py 2014-09-03 17:23:52 +0000
@@ -37,6 +37,7 @@
37 login_conf_fn = '/etc/login.conf'37 login_conf_fn = '/etc/login.conf'
38 login_conf_fn_bak = '/etc/login.conf.orig'38 login_conf_fn_bak = '/etc/login.conf.orig'
39 resolv_conf_fn = '/etc/resolv.conf'39 resolv_conf_fn = '/etc/resolv.conf'
40 ci_sudoers_fn = '/usr/local/etc/sudoers.d/90-cloud-init-users'
4041
41 def __init__(self, name, cfg, paths):42 def __init__(self, name, cfg, paths):
42 distros.Distro.__init__(self, name, cfg, paths)43 distros.Distro.__init__(self, name, cfg, paths)
@@ -219,10 +220,6 @@
219 util.logexc(LOG, "Failed to lock user %s", name)220 util.logexc(LOG, "Failed to lock user %s", name)
220 raise e221 raise e
221222
222 # TODO:
223 def write_sudo_rules(self, name, rules, sudo_file=None):
224 LOG.debug("[write_sudo_rules] Name: %s", name)
225
226 def create_user(self, name, **kwargs):223 def create_user(self, name, **kwargs):
227 self.add_user(name, **kwargs)224 self.add_user(name, **kwargs)
228225
229226
=== modified file 'tools/build-on-freebsd'
--- tools/build-on-freebsd 2014-08-23 12:16:03 +0000
+++ tools/build-on-freebsd 2014-09-03 17:23:52 +0000
@@ -17,6 +17,7 @@
17 py27-prettytable17 py27-prettytable
18 py27-requests py27-six18 py27-requests py27-six
19 python py27-cheetah19 python py27-cheetah
20 py27-jsonpointer py27-jsonpatch
20"21"
21[ -f "$depschecked" ] || pkg install ${pkgs} || fail "install packages"22[ -f "$depschecked" ] || pkg install ${pkgs} || fail "install packages"
22touch $depschecked23touch $depschecked