Code review comment for lp:~harlowja/cloud-init/ssh-auth-keys

Revision history for this message
Scott Moser (smoser) wrote :

This looks fine. Ideally there'd be some tests...
The only other comment is that it seems like '_gen_fingerprint' as well be part of ssh_util, and even have 'fingerprint' be returned by AuthKeyLineParser:parse, but nothing else uses that now, so that seems not necessary.

review: Approve

« Back to merge proposal