Merge lp:~harlowja/cloud-init/rpm-private-release-num into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Merged
Merged at revision: 686
Proposed branch: lp:~harlowja/cloud-init/rpm-private-release-num
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 41 lines (+12/-1)
2 files modified
packages/brpm (+11/-0)
packages/redhat/cloud-init.spec.in (+1/-1)
To merge this branch: bzr merge lp:~harlowja/cloud-init/rpm-private-release-num
Reviewer Review Type Date Requested Status
cloud-init Commiters Pending
Review via email: mp+128603@code.launchpad.net
To post a comment you must log in.
687. By Joshua Harlow

Make the subrelease a new k/v entry that is handled
differently in the rpm spec file template instead
of being joined with the release.

Revision history for this message
Joshua Harlow (harlowja) wrote :

Tried it out and it seems to work, so since this is a rpm only change I'll commit it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'packages/brpm'
--- packages/brpm 2012-10-05 18:31:56 +0000
+++ packages/brpm 2012-10-08 23:36:19 +0000
@@ -106,6 +106,10 @@
106 subs['version'] = version106 subs['version'] = version
107 subs['revno'] = revno107 subs['revno'] = revno
108 subs['release'] = "bzr%s" % (revno)108 subs['release'] = "bzr%s" % (revno)
109 if args.sub_release is not None:
110 subs['subrelease'] = "." + str(args.sub_release)
111 else:
112 subs['subrelease'] = ''
109 subs['archive_name'] = arc_fn113 subs['archive_name'] = arc_fn
110114
111 cmd = [util.abs_join(find_root(), 'tools', 'read-dependencies')]115 cmd = [util.abs_join(find_root(), 'tools', 'read-dependencies')]
@@ -175,6 +179,13 @@
175 " (default: %(default)s)"),179 " (default: %(default)s)"),
176 default=False,180 default=False,
177 action='store_true')181 action='store_true')
182 parser.add_argument('-s', "--sub-release", dest="sub_release",
183 metavar="RELEASE",
184 help=("a 'internal' release number to concat"
185 " with the bzr version number to form"
186 " the final version number"),
187 type=int,
188 default=None)
178 parser.add_argument("-p", "--patch", dest="patches",189 parser.add_argument("-p", "--patch", dest="patches",
179 help=("include the following patch when building"),190 help=("include the following patch when building"),
180 default=[],191 default=[],
181192
=== modified file 'packages/redhat/cloud-init.spec.in'
--- packages/redhat/cloud-init.spec.in 2012-09-27 00:03:07 +0000
+++ packages/redhat/cloud-init.spec.in 2012-10-08 23:36:19 +0000
@@ -11,7 +11,7 @@
1111
12Name: cloud-init12Name: cloud-init
13Version: ${version}13Version: ${version}
14Release: ${release}%{?dist}14Release: ${release}${subrelease}%{?dist}
15Summary: Cloud instance init scripts15Summary: Cloud instance init scripts
1616
17Group: System Environment/Base17Group: System Environment/Base