Merge lp:~harlowja/cloud-init/cloud-init-tag-distros into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~harlowja/cloud-init/cloud-init-tag-distros
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 64 lines (+10/-0)
5 files modified
cloudinit/config/cc_lxd.py (+2/-0)
cloudinit/config/cc_rh_subscription.py (+2/-0)
cloudinit/config/cc_snappy.py (+2/-0)
cloudinit/config/cc_ubuntu_init_switch.py (+2/-0)
cloudinit/config/cc_yum_add_repo.py (+2/-0)
To merge this branch: bzr merge lp:~harlowja/cloud-init/cloud-init-tag-distros
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
cloud-init Commiters Pending
Review via email: mp+300840@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:1259
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~harlowja/cloud-init/cloud-init-tag-distros/+merge/300840/+edit-commit-message

https://server-team-jenkins.canonical.com/job/cloud-init-ci/34/
Executed test runs:
    None: https://server-team-jenkins.canonical.com/job/lp-vote-on-merge/8/console

Click here to trigger a rebuild:
https://server-team-jenkins.canonical.com/job/cloud-init-ci/34/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

fwiw, I think the changes here are actually merged.

Unmerged revisions

1259. By Joshua Harlow

Add distro tags on config modules that should have it

Some of these really won't work to well on non-supporting
distros so to avoid further user pain tag this with the
supported distros where they should work.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cloudinit/config/cc_lxd.py'
--- cloudinit/config/cc_lxd.py 2016-06-03 04:42:22 +0000
+++ cloudinit/config/cc_lxd.py 2016-07-22 07:10:01 +0000
@@ -47,6 +47,8 @@
4747
48from cloudinit import util48from cloudinit import util
4949
50distros = ['ubuntu']
51
5052
51def handle(name, cfg, cloud, log, args):53def handle(name, cfg, cloud, log, args):
52 # Get config54 # Get config
5355
=== modified file 'cloudinit/config/cc_rh_subscription.py'
--- cloudinit/config/cc_rh_subscription.py 2016-04-06 17:57:00 +0000
+++ cloudinit/config/cc_rh_subscription.py 2016-07-22 07:10:01 +0000
@@ -18,6 +18,8 @@
1818
19from cloudinit import util19from cloudinit import util
2020
21distros = ['fedora', 'rhel']
22
2123
22def handle(name, cfg, _cloud, log, _args):24def handle(name, cfg, _cloud, log, _args):
23 sm = SubscriptionManager(cfg)25 sm = SubscriptionManager(cfg)
2426
=== modified file 'cloudinit/config/cc_snappy.py'
--- cloudinit/config/cc_snappy.py 2016-05-12 17:56:26 +0000
+++ cloudinit/config/cc_snappy.py 2016-07-22 07:10:01 +0000
@@ -68,6 +68,8 @@
68 'config': {},68 'config': {},
69}69}
7070
71distros = ['ubuntu']
72
7173
72def parse_filename(fname):74def parse_filename(fname):
73 fname = os.path.basename(fname)75 fname = os.path.basename(fname)
7476
=== modified file 'cloudinit/config/cc_ubuntu_init_switch.py'
--- cloudinit/config/cc_ubuntu_init_switch.py 2016-05-12 17:56:26 +0000
+++ cloudinit/config/cc_ubuntu_init_switch.py 2016-07-22 07:10:01 +0000
@@ -86,6 +86,8 @@
86fi86fi
87"""87"""
8888
89distros = ['ubuntu']
90
8991
90def handle(name, cfg, cloud, log, args):92def handle(name, cfg, cloud, log, args):
91 """Handler method activated by cloud-init."""93 """Handler method activated by cloud-init."""
9294
=== modified file 'cloudinit/config/cc_yum_add_repo.py'
--- cloudinit/config/cc_yum_add_repo.py 2016-03-03 22:20:10 +0000
+++ cloudinit/config/cc_yum_add_repo.py 2016-07-22 07:10:01 +0000
@@ -23,6 +23,8 @@
2323
24from cloudinit import util24from cloudinit import util
2525
26distros = ['fedora', 'rhel']
27
2628
27def _canonicalize_id(repo_id):29def _canonicalize_id(repo_id):
28 repo_id = repo_id.lower().replace("-", "_")30 repo_id = repo_id.lower().replace("-", "_")