Merge lp:~harlowja/cloud-init/cloud-init-tag-distros into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~harlowja/cloud-init/cloud-init-tag-distros
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 64 lines (+10/-0)
5 files modified
cloudinit/config/cc_lxd.py (+2/-0)
cloudinit/config/cc_rh_subscription.py (+2/-0)
cloudinit/config/cc_snappy.py (+2/-0)
cloudinit/config/cc_ubuntu_init_switch.py (+2/-0)
cloudinit/config/cc_yum_add_repo.py (+2/-0)
To merge this branch: bzr merge lp:~harlowja/cloud-init/cloud-init-tag-distros
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
cloud-init Commiters Pending
Review via email: mp+300840@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:1259
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~harlowja/cloud-init/cloud-init-tag-distros/+merge/300840/+edit-commit-message

https://server-team-jenkins.canonical.com/job/cloud-init-ci/34/
Executed test runs:
    None: https://server-team-jenkins.canonical.com/job/lp-vote-on-merge/8/console

Click here to trigger a rebuild:
https://server-team-jenkins.canonical.com/job/cloud-init-ci/34/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

fwiw, I think the changes here are actually merged.

Unmerged revisions

1259. By Joshua Harlow

Add distro tags on config modules that should have it

Some of these really won't work to well on non-supporting
distros so to avoid further user pain tag this with the
supported distros where they should work.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/config/cc_lxd.py'
2--- cloudinit/config/cc_lxd.py 2016-06-03 04:42:22 +0000
3+++ cloudinit/config/cc_lxd.py 2016-07-22 07:10:01 +0000
4@@ -47,6 +47,8 @@
5
6 from cloudinit import util
7
8+distros = ['ubuntu']
9+
10
11 def handle(name, cfg, cloud, log, args):
12 # Get config
13
14=== modified file 'cloudinit/config/cc_rh_subscription.py'
15--- cloudinit/config/cc_rh_subscription.py 2016-04-06 17:57:00 +0000
16+++ cloudinit/config/cc_rh_subscription.py 2016-07-22 07:10:01 +0000
17@@ -18,6 +18,8 @@
18
19 from cloudinit import util
20
21+distros = ['fedora', 'rhel']
22+
23
24 def handle(name, cfg, _cloud, log, _args):
25 sm = SubscriptionManager(cfg)
26
27=== modified file 'cloudinit/config/cc_snappy.py'
28--- cloudinit/config/cc_snappy.py 2016-05-12 17:56:26 +0000
29+++ cloudinit/config/cc_snappy.py 2016-07-22 07:10:01 +0000
30@@ -68,6 +68,8 @@
31 'config': {},
32 }
33
34+distros = ['ubuntu']
35+
36
37 def parse_filename(fname):
38 fname = os.path.basename(fname)
39
40=== modified file 'cloudinit/config/cc_ubuntu_init_switch.py'
41--- cloudinit/config/cc_ubuntu_init_switch.py 2016-05-12 17:56:26 +0000
42+++ cloudinit/config/cc_ubuntu_init_switch.py 2016-07-22 07:10:01 +0000
43@@ -86,6 +86,8 @@
44 fi
45 """
46
47+distros = ['ubuntu']
48+
49
50 def handle(name, cfg, cloud, log, args):
51 """Handler method activated by cloud-init."""
52
53=== modified file 'cloudinit/config/cc_yum_add_repo.py'
54--- cloudinit/config/cc_yum_add_repo.py 2016-03-03 22:20:10 +0000
55+++ cloudinit/config/cc_yum_add_repo.py 2016-07-22 07:10:01 +0000
56@@ -23,6 +23,8 @@
57
58 from cloudinit import util
59
60+distros = ['fedora', 'rhel']
61+
62
63 def _canonicalize_id(repo_id):
64 repo_id = repo_id.lower().replace("-", "_")