Code review comment for ~harald-jensas/cloud-init:bug/1847517

Revision history for this message
Harald Jensås (harald-jensas) wrote :

> thanks for the well done bug report and merge proposal!
>
> Please add a test to the unfortunately long and difficult to follow
> tests/unittests/test_net.py .
>

Thanks, I did'nt find these tests in my first iteration.
I added tests in tests/unittests/test_datasource/test_configdrive.py and tests/unittests/test_net.py.

> Also, as this is your first submission:
>
> To contribute, you must sign the Canonical Contributor License Agreement
> (CLA) [1].
>

I've submitted the form.

« Back to merge proposal