Code review comment for lp:~happyhouse19/ubuntu/oneiric/spyder/fix-for-890243

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Matthew.

Thanks for the patch! I have some notes though:
- you didn't target the right branch (you targeted the oneiric branch, not precise one)
- debian/changelog target "oneiric" and not "precise" :)
- also, you made an inline patch. We tend to avoid doing that and using a patch system (this one is using quilt). For more information please look at https://wiki.ubuntu.com/PackagingGuide.
- finally, this patch should definitively be sent to upstream (eventually debian). Can you please take care of that?

Anyway, I've fixed the 3 first bullet and sponsored to precise. Thanks! Marking the branch as merged.

review: Approve

« Back to merge proposal