Nux

Code review comment for lp:~haggai-eran/nux/rtl-logical-packing

Revision history for this message
Tim Penhey (thumper) wrote :

Just a few minor style things from me:
 * member variables should have trailing not leading underscore
  (parts being updated as we get to them)
 * no space before function call parenthesis
 * please use C++ style enum definitions (not typedef)

   enum Direction
   {
      // values...
   };

I'll let Jay do the actual functionality bits.

review: Needs Fixing

« Back to merge proposal