Code review comment for lp:~gz/juju-core/openstack_network_config_1241674

Revision history for this message
Martin Packman (gz) wrote :

Please take a look.

https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go
File provider/openstack/provider.go (right):

https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go#newcode79
provider/openstack/provider.go:79: # networks specifies the network
label or uuid to bring machines up on, in
On 2014/01/24 20:12:45, nate.finch wrote:
> s/networks/network

Will fix... I did plan to allow supplying multiple initially, but we'll
leave that for later.

https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go#newcode642
provider/openstack/provider.go:642: var uuidRegexp =
regexp.MustCompile(uuidPattern)
On 2014/01/24 20:12:45, nate.finch wrote:
> Seems like there ought to be a function that verifies guids in Go
instead of
> hand-writing a regex...

Yes, yes there should. The best I could find was:

<https://github.com/nu7hatch/gouuid/blob/master/uuid.go>

https://codereview.appspot.com/52710048/

« Back to merge proposal