LGTM with a couple small points.
https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go File provider/openstack/provider.go (right):
https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go#newcode79 provider/openstack/provider.go:79: # networks specifies the network label or uuid to bring machines up on, in s/networks/network
https://codereview.appspot.com/52710048/diff/20001/provider/openstack/provider.go#newcode642 provider/openstack/provider.go:642: var uuidRegexp = regexp.MustCompile(uuidPattern) Seems like there ought to be a function that verifies guids in Go instead of hand-writing a regex...
https://codereview.appspot.com/52710048/
« Back to merge proposal
LGTM with a couple small points.
https:/ /codereview. appspot. com/52710048/ diff/20001/ provider/ openstack/ provider. go openstack/ provider. go (right):
File provider/
https:/ /codereview. appspot. com/52710048/ diff/20001/ provider/ openstack/ provider. go#newcode79 openstack/ provider. go:79: # networks specifies the network
provider/
label or uuid to bring machines up on, in
s/networks/network
https:/ /codereview. appspot. com/52710048/ diff/20001/ provider/ openstack/ provider. go#newcode642 openstack/ provider. go:642: var uuidRegexp = MustCompile( uuidPattern)
provider/
regexp.
Seems like there ought to be a function that verifies guids in Go
instead of hand-writing a regex...
https:/ /codereview. appspot. com/52710048/