Yeah, config named 'network' is bad, but I think config for this at all
is bad. And it should take multiple values. I am resolved to leave some
bikeshedding for post 1.17.1 over this. :)
Sadly our errors through goose are massively verbose, and the real
errors from (older at least) openstack versions are actually this
impresice. It might be an argument for doing more prechecking even when
a valid uuid is supplied.
Please take a look.
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go openstack/ local_test. go (right):
File provider/
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go#newcode364 openstack/ local_test. go:364: "network": 7dec-11d0- a765-00a0c91e6b f6",
provider/
"f81d4fae-
On 2014/01/24 16:53:49, fwereade wrote:
> a thought: default-network? private-network?
Yeah, config named 'network' is bad, but I think config for this at all
is bad. And it should take multiple values. I am resolved to leave some
bikeshedding for post 1.17.1 over this. :)
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go#newcode371 openstack/ local_test. go:371: c.Assert(err, gc.ErrorMatches,
provider/
"(?s)cannot run instance: .*itemNotFound.*")
On 2014/01/24 16:53:49, fwereade wrote:
> I'd like to see a more precise error check here really.
Sadly our errors through goose are massively verbose, and the real
errors from (older at least) openstack versions are actually this
impresice. It might be an argument for doing more prechecking even when
a valid uuid is supplied.
https:/ /codereview. appspot. com/52710048/