Code review comment for lp:~gz/juju-core/openstack_network_config_1241674

Revision history for this message
Martin Packman (gz) wrote :

Please take a look.

https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go
File provider/openstack/local_test.go (right):

https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go#newcode364
provider/openstack/local_test.go:364: "network":
"f81d4fae-7dec-11d0-a765-00a0c91e6bf6",
On 2014/01/24 16:53:49, fwereade wrote:
> a thought: default-network? private-network?

Yeah, config named 'network' is bad, but I think config for this at all
is bad. And it should take multiple values. I am resolved to leave some
bikeshedding for post 1.17.1 over this. :)

https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go#newcode371
provider/openstack/local_test.go:371: c.Assert(err, gc.ErrorMatches,
"(?s)cannot run instance: .*itemNotFound.*")
On 2014/01/24 16:53:49, fwereade wrote:
> I'd like to see a more precise error check here really.

Sadly our errors through goose are massively verbose, and the real
errors from (older at least) openstack versions are actually this
impresice. It might be an argument for doing more prechecking even when
a valid uuid is supplied.

https://codereview.appspot.com/52710048/

« Back to merge proposal