quick comments -- thoughts?
https://codereview.appspot.com/52710048/diff/1/provider/openstack/config.go File provider/openstack/config.go (right):
https://codereview.appspot.com/52710048/diff/1/provider/openstack/config.go#newcode42 provider/openstack/config.go:42: "network": "", this feels like maybe it should be an Omit?
https://codereview.appspot.com/52710048/diff/1/provider/openstack/config.go#newcode95 provider/openstack/config.go:95: return c.attrs["network"].(string) and this a `,ok`?
https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go File provider/openstack/local_test.go (right):
https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go#newcode364 provider/openstack/local_test.go:364: "network": "f81d4fae-7dec-11d0-a765-00a0c91e6bf6", a thought: default-network? private-network?
https://codereview.appspot.com/52710048/diff/1/provider/openstack/local_test.go#newcode371 provider/openstack/local_test.go:371: c.Assert(err, gc.ErrorMatches, "(?s)cannot run instance: .*itemNotFound.*") I'd like to see a more precise error check here really.
https://codereview.appspot.com/52710048/
« Back to merge proposal
quick comments -- thoughts?
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ config. go openstack/ config. go (right):
File provider/
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ config. go#newcode42 openstack/ config. go:42: "network": "",
provider/
this feels like maybe it should be an Omit?
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ config. go#newcode95 openstack/ config. go:95: return c.attrs[ "network" ].(string)
provider/
and this a `,ok`?
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go openstack/ local_test. go (right):
File provider/
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go#newcode364 openstack/ local_test. go:364: "network": 7dec-11d0- a765-00a0c91e6b f6",
provider/
"f81d4fae-
a thought: default-network? private-network?
https:/ /codereview. appspot. com/52710048/ diff/1/ provider/ openstack/ local_test. go#newcode371 openstack/ local_test. go:371: c.Assert(err, gc.ErrorMatches,
provider/
"(?s)cannot run instance: .*itemNotFound.*")
I'd like to see a more precise error check here really.
https:/ /codereview. appspot. com/52710048/