Code review comment for lp:~gz/juju-core/add_state_address

Revision history for this message
Martin Packman (gz) wrote :

Please take a look.

https://codereview.appspot.com/11284044/diff/1/state/address.go
File state/address.go (right):

https://codereview.appspot.com/11284044/diff/1/state/address.go#newcode25
state/address.go:25: NetworkCloudLocal NetworkScope = "local-cloud"
On 2013/07/18 02:38:57, thumper wrote:
> So a "local-cloud" address is what we currently call a private
address?

Yes. Thee public interfaces will still be in terms of "private address"
I just wanted to keep the distinction between a 10. address routed
across a cloud region and a 10. address set up by lxc say.

https://codereview.appspot.com/11284044/diff/1/state/address.go#newcode32
state/address.go:32: Name string
On 2013/07/15 21:50:43, fwereade wrote:
> Wondering if this is more "Value" than "Name"?

Changed.

https://codereview.appspot.com/11284044/

« Back to merge proposal