juju-core

Code review comment for lp:~gz/juju-core/add_state_address

  1. add_state_address
  2. Merge into trunk
Revision history for this message
William Reade (fwereade) wrote :

Looks sane to me. If this is intended for merging, LGTM :).

https://codereview.appspot.com/11284044/diff/1/state/address.go
File state/address.go (right):

https://codereview.appspot.com/11284044/diff/1/state/address.go#newcode32
state/address.go:32: Name string
Wondering if this is more "Value" than "Name"?

https://codereview.appspot.com/11284044/

« Back to merge proposal