Code review comment for lp:~gz/juju-core/add_copyright_headers

Reviewers: mp+162139_code.launchpad.net,

Message:
Please take a look.

Description:
Add per-file copyright headers

As requested during the release process for Ubuntu, we need a copyright
statement at the top of source files. I have deliberately excluded
documentation and non-go code for now, pending feedback. Because bzr
already
has a fancy tool for doing the years from the revision history, the year
stated
comes from there rather than being project-wide.

The changes in this branch were generated using the following script:

 #!/bin/sh
 set -e
 L1=" Copyright 2013, Canonical Ltd.\n"
 L2=" Licensed under the AGPLv3, see LICENCE file for details.\n"
 find . -name thirdparty -prune -o -name "*.go" -print0|xargs -0 sed -i
-e "1i//${L1}//${L2}"
 #chmod 755 scripts/release-public-tools/release-public-tools.sh
 #find . -executable -type f -print0|xargs -0 sed -i -e "2i#${L1}#${L2}"
 #sed -i -e "1i#${L1}#${L2}" scripts/jujuman.py
 bzr update-copyright

Note that I've not included the logic for adding the header to python
and shell
scripts when creating this branch. There are only a few of them, and
making the
output pretty in an automated fashion is harder.

https://code.launchpad.net/~gz/juju-core/add_copyright_headers/+merge/162139

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9104045/

Affected files:
   A [revision details]
   M bzr/bzr.go
   M bzr/bzr_test.go
   M cert/cert.go
   M cert/cert_test.go
   M charm/bundle.go
   M charm/bundle_test.go
   M charm/charm.go
   M charm/charm_test.go
   M charm/config.go
   M charm/config_test.go
   M charm/dir.go
   M charm/dir_test.go
   M charm/export_test.go
   M charm/hooks/hooks.go
   M charm/meta.go
   M charm/meta_test.go
   M charm/repo.go
   M charm/repo_test.go
   M charm/url.go
   M charm/url_test.go
   M cloudinit/cloudinit.go
   M cloudinit/cloudinit_test.go
   M cloudinit/options.go
   M cmd/builddb/main.go
   M cmd/charmd/main.go
   M cmd/charmload/main.go
   M cmd/cmd.go
   M cmd/cmd_test.go
   M cmd/filevar.go
   M cmd/filevar_test.go
   M cmd/juju/addrelation.go
   M cmd/juju/addrelation_test.go
   M cmd/juju/addunit.go
   M cmd/juju/addunit_test.go
   M cmd/juju/bootstrap.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/cmd_test.go
   M cmd/juju/config_test.go
   M cmd/juju/constraints.go
   M cmd/juju/constraints_test.go
   M cmd/juju/debuglog.go
   M cmd/juju/debuglog_test.go
   M cmd/juju/deploy.go
   M cmd/juju/deploy_test.go
   M cmd/juju/destroyenvironment.go
   M cmd/juju/destroymachine.go
   M cmd/juju/destroymachine_test.go
   M cmd/juju/destroyrelation.go
   M cmd/juju/destroyrelation_test.go
   M cmd/juju/destroyservice.go
   M cmd/juju/destroyservice_test.go
   M cmd/juju/destroyunit.go
   M cmd/juju/destroyunit_test.go
   M cmd/juju/environment.go
   M cmd/juju/environment_test.go
   M cmd/juju/environmentcommand.go
   M cmd/juju/expose.go
   M cmd/juju/expose_test.go
   M cmd/juju/get.go
   M cmd/juju/help_topics.go
   M cmd/juju/init.go
   M cmd/juju/init_test.go
   M cmd/juju/main.go
   M cmd/juju/main_test.go
   M cmd/juju/publish.go
   M cmd/juju/publish_test.go
   M cmd/juju/resolved.go
   M cmd/juju/resolved_test.go
   M cmd/juju/scp.go
   M cmd/juju/scp_test.go
   M cmd/juju/set.go
   M cmd/juju/ssh.go
   M cmd/juju/ssh_test.go
   M cmd/juju/status.go
   M cmd/juju/status_test.go
   M cmd/juju/synctools.go
   M cmd/juju/synctools_test.go
   M cmd/juju/unexpose.go
   M cmd/juju/unexpose_test.go
   M cmd/juju/upgradecharm.go
   M cmd/juju/upgradecharm_test.go
   M cmd/juju/upgradejuju.go
   M cmd/juju/upgradejuju_test.go
   M cmd/jujud/agent.go
   M cmd/jujud/agent_test.go
   M cmd/jujud/bootstrap.go
   M cmd/jujud/bootstrap_test.go
   M cmd/jujud/deploy_test.go
   M cmd/jujud/machine.go
   M cmd/jujud/machine_test.go
   M cmd/jujud/main.go
   M cmd/jujud/main_test.go
   M cmd/jujud/unit.go
   M cmd/jujud/unit_test.go
   M cmd/jujud/upgrade.go
   M cmd/jujud/upgrade_test.go
   M cmd/logging.go
   M cmd/logging_test.go
   M cmd/output.go
   M cmd/output_test.go
   M cmd/supercommand.go
   M cmd/supercommand_test.go
   M cmd/util_test.go
   M cmd/version.go
   M cmd/version_test.go
   M constraints/constraints.go
   M constraints/constraints_test.go
   M downloader/downloader.go
   M downloader/downloader_test.go
   M environs/agent/agent.go
   M environs/agent/agent_test.go
   M environs/agent/tools.go
   M environs/agent/tools_test.go
   M environs/all/all.go
   M environs/boilerplate_config.go
   M environs/boilerplate_config_test.go
   M environs/bootstrap.go
   M environs/bootstrap_test.go
   M environs/cert.go
   M environs/cert_internal_test.go
   M environs/cert_test.go
   M environs/cloudinit.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M environs/cloudinit/suite_test.go
   M environs/cloudinit_test.go
   M environs/config.go
   M environs/config/authkeys.go
   M environs/config/config.go
   M environs/config/config_test.go
   M environs/config/home.go
   M environs/config/home_test.go
   M environs/config_test.go
   M environs/dummy/config_test.go
   M environs/dummy/environs.go
   M environs/dummy/environs_test.go
   M environs/dummy/storage.go
   M environs/ec2/config.go
   M environs/ec2/config_test.go
   M environs/ec2/ec2.go
   M environs/ec2/export_test.go
   M environs/ec2/image.go
   M environs/ec2/image_test.go
   M environs/ec2/instancetype.go
   M environs/ec2/live_test.go
   M environs/ec2/local_test.go
   M environs/ec2/state.go
   M environs/ec2/storage.go
   M environs/ec2/suite_test.go
   M environs/export_test.go
   M environs/instances/image.go
   M environs/instances/image_test.go
   M environs/instances/instancetype.go
   M environs/instances/instancetype_test.go
   M environs/interface.go
   M environs/jujutest/jujutest_test.go
   M environs/jujutest/livetests.go
   M environs/jujutest/metadata.go
   M environs/jujutest/metadata_test.go
   M environs/jujutest/tests.go
   M environs/local/backend.go
   M environs/local/backend_test.go
   M environs/local/export_test.go
   M environs/local/storage.go
   M environs/local/storage_test.go
   M environs/maas/config.go
   M environs/maas/config_test.go
   M environs/maas/environ.go
   M environs/maas/environ_test.go
   M environs/maas/environprovider.go
   M environs/maas/environprovider_test.go
   M environs/maas/instance.go
   M environs/maas/instance_test.go
   M environs/maas/maas_test.go
   M environs/maas/state.go
   M environs/maas/state_test.go
   M environs/maas/storage.go
   M environs/maas/storage_test.go
   M environs/maas/util.go
   M environs/maas/util_test.go
   M environs/mongo.go
   M environs/mongo_test.go
   M environs/open.go
   M environs/open_test.go
   M environs/openstack/config.go
   M environs/openstack/config_test.go
   M environs/openstack/export_test.go
   M environs/openstack/image.go
   M environs/openstack/live_test.go
   M environs/openstack/local_test.go
   M environs/openstack/provider.go
   M environs/openstack/provider_test.go
   M environs/openstack/state.go
   M environs/openstack/storage.go
   M environs/storage.go
   M environs/storage_test.go
   M environs/suite_test.go
   M environs/testing/instances.go
   M environs/testing/tools.go
   [[ 201 additional files ]]