https://codereview.appspot.com/56560043/diff/20001/provider/common/state.go#newcode71
provider/common/state.go:71: func LoadStateFromURL(url string,
disableSSLHostnameVerification bool) (*BootstrapState, error) {
This is fine for now, but I wonder if we shouldn't have a method of
obtaining an http.Client for an environment. We now have HTTP proxy
settings and SSL hostname verification as options. We could centralise
all that and pass an http.Client in here.
https:/ /codereview. appspot. com/56560043/ diff/20001/ environs/ httpstorage/ storage. go httpstorage/ storage. go (right):
File environs/
https:/ /codereview. appspot. com/56560043/ diff/20001/ environs/ httpstorage/ storage. go#newcode26 httpstorage/ storage. go:26: type PromotableStorage interface { httputil. ReverseProxy.
environs/
I'm not keen on this. I think a better way to test, rather than further
exposing the guts of this package, would be to use a
net/http/
https:/ /codereview. appspot. com/56560043/ diff/20001/ provider/ common/ state.go common/ state.go (right):
File provider/
https:/ /codereview. appspot. com/56560043/ diff/20001/ provider/ common/ state.go# newcode71 common/ state.go: 71: func LoadStateFromUR L(url string, ameVerification bool) (*BootstrapState, error) {
provider/
disableSSLHostn
This is fine for now, but I wonder if we shouldn't have a method of
obtaining an http.Client for an environment. We now have HTTP proxy
settings and SSL hostname verification as options. We could centralise
all that and pass an http.Client in here.
https:/ /codereview. appspot. com/56560043/