Merge lp:~gz/juju-ci-tools/fix_git_gate_tests into lp:juju-ci-tools

Proposed by Martin Packman
Status: Merged
Approved by: Martin Packman
Approved revision: 914
Merged at revision: 914
Proposed branch: lp:~gz/juju-ci-tools/fix_git_gate_tests
Merge into: lp:juju-ci-tools
Diff against target: 50 lines (+10/-5)
1 file modified
test_git_gate.py (+10/-5)
To merge this branch: bzr merge lp:~gz/juju-ci-tools/fix_git_gate_tests
Reviewer Review Type Date Requested Status
John George (community) Approve
Review via email: mp+254626@code.launchpad.net

Description of the change

Fix broken tests for git gate script

Changed arg handling added a new restriction that the test cases had not picked up the adaptation for.

To post a comment you must log in.
Revision history for this message
John George (jog) wrote :

Thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'test_git_gate.py'
--- test_git_gate.py 2015-03-24 18:48:23 +0000
+++ test_git_gate.py 2015-03-30 18:54:24 +0000
@@ -6,20 +6,23 @@
66
7class TestParseArgs(unittest.TestCase):7class TestParseArgs(unittest.TestCase):
88
9 def test_project_only(self):9 def test_project_and_url(self):
10 args = git_gate.parse_args(["--project", "git.testing/project"])10 args = git_gate.parse_args(
11 ["--project", "git.testing/project",
12 "--project-url", "https://git.testing/project"])
11 self.assertEqual(args.project, "git.testing/project")13 self.assertEqual(args.project, "git.testing/project")
14 self.assertEqual(args.project_url, "https://git.testing/project")
1215
13 def test_project_and_ref(self):16 def test_project_and_ref(self):
14 args = git_gate.parse_args(17 args = git_gate.parse_args(
15 ["--project", "git.testing/project",18 ["--project", "git.testing/project", "--go-get-all",
16 "--project-ref", "v1"])19 "--project-ref", "v1"])
17 self.assertEqual(args.project, "git.testing/project")20 self.assertEqual(args.project, "git.testing/project")
18 self.assertEqual(args.project_ref, "v1")21 self.assertEqual(args.project_ref, "v1")
1922
20 def test_merging_other(self):23 def test_merging_other(self):
21 args = git_gate.parse_args(24 args = git_gate.parse_args(
22 ["--project", "git.testing/project",25 ["--project", "git.testing/project", "--go-get-all",
23 "--merge-url", "git.testing/proposed"])26 "--merge-url", "git.testing/proposed"])
24 self.assertEqual(args.project, "git.testing/project")27 self.assertEqual(args.project, "git.testing/project")
25 self.assertEqual(args.merge_url, "git.testing/proposed")28 self.assertEqual(args.merge_url, "git.testing/proposed")
@@ -27,7 +30,7 @@
2730
28 def test_merging_other_ref(self):31 def test_merging_other_ref(self):
29 args = git_gate.parse_args(32 args = git_gate.parse_args(
30 ["--project", "git.testing/project",33 ["--project", "git.testing/project", "--go-get-all",
31 "--merge-url", "git.testing/proposed", "--merge-ref", "feature"])34 "--merge-url", "git.testing/proposed", "--merge-ref", "feature"])
32 self.assertEqual(args.project, "git.testing/project")35 self.assertEqual(args.project, "git.testing/project")
33 self.assertEqual(args.merge_url, "git.testing/proposed")36 self.assertEqual(args.merge_url, "git.testing/proposed")
@@ -36,8 +39,10 @@
36 def test_project_with_deps(self):39 def test_project_with_deps(self):
37 args = git_gate.parse_args(40 args = git_gate.parse_args(
38 ["--project", "git.testing/project",41 ["--project", "git.testing/project",
42 "--project-url", "https://git.testing/project",
39 "--dependencies", "git.testing/a", "git.testing/b"])43 "--dependencies", "git.testing/a", "git.testing/b"])
40 self.assertEqual(args.project, "git.testing/project")44 self.assertEqual(args.project, "git.testing/project")
45 self.assertEqual(args.project_url, "https://git.testing/project")
41 self.assertEqual(args.dependencies, ["git.testing/a", "git.testing/b"])46 self.assertEqual(args.dependencies, ["git.testing/a", "git.testing/b"])
42 self.assertEqual(args.go_get_all, False)47 self.assertEqual(args.go_get_all, False)
4348

Subscribers

People subscribed via source and target branches