Code review comment for lp:~gz/hydrazine/use_bzr_config_email_561211

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/9/2011 1:07 AM, Martin Packman wrote:
> Martin Packman has proposed merging
> lp:~gz/hydrazine/use_bzr_config_email_561211 into lp:hydrazine.
>
> Requested reviews: hydrazine-core (hydrazine-core)
>
> For more details, see:
> https://code.launchpad.net/~gz/hydrazine/use_bzr_config_email_561211/+merge/78738
>
> Currently hydrazine insists on looking at $EMAIL for your address,
> complains if it's not set, then looks at what your launchpad
> account has as your preferred email. This branch changes it to just
> use Bazaar's config instead, which is already needed for the GPG
> settings and will check $BZR_EMAIL, bazaar.conf, $EMAIL, then
> platform specific settings in that order.
>
> Perhaps a (non-warning) print should be added back in to say which
> email is actually being used as this is a slight behaviour change
> and might surprise some people if they have funny bzr settings but
> sensible launchpad settings?

Looks fine to me. I wonder if we could have
launchpad.me.preferred_email_address.email somehow as a fallback. I
think config can raise an exception if it can't determine an email
address?

(Not voting, because I don't think I actually have voting rights, and
Launchpad will reject my comment.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6SlqIACgkQJdeBCYSNAAO/ogCdEVQPeQGiegpXHIKixyKpS491
sRMAoID4LwEwFo4GZcFyY5a0uMukTSZO
=xJ1/
-----END PGP SIGNATURE-----