lp:~gz/goose/tool_test_weirdness

Created by Martin Packman on 2014-05-01 and last modified on 2014-05-01
Get this branch:
bzr branch lp:~gz/goose/tool_test_weirdness
Only Martin Packman can upload to this branch. If you are Martin Packman please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Martin Packman
Project:
Go OpenStack Exchange
Status:
Merged

Recent revisions

120. By Martin Packman on 2014-05-01

Tweak tools tests to work around weird issueon bot

119. By Andrew Wilkins on 2014-04-23

[r=axwalk] http: close response body if unused

BinaryRequest calls may discard the response
without closing it. This was causing sockets
to be left open in juju-core/provider/openstack
tests, leading to test failures.

https://codereview.appspot.com/90540043/

118. By John A Meinel on 2014-03-07

[r=jameinel],[bug=1226996] panic if we get bad requests

It turns out that if you don't supply CIDR or GroupId Openstack just
sets CIDR to 0.0.0.0/0. We don't want to rely on that behavior, so
this just changes the goose test double to panic if it got that
situation.

This can't land until we land my updated Juju branch (or the test
suite will appropriately fail with panic().)

https://codereview.appspot.com/13781043/

117. By Dave Cheney on 2014-02-06

[r=dave-cheney] Make test pass on gccgo 4.8

gccgo 4.8 and 4.9 have a different view on the number of callers on the call stack.

Attempt to detect the correct value automatically.

116. By Martin Packman on 2014-01-24

[r=gz] Add networks attribute to RunServer params

This enables the starting of a server on a specific
network, which is required for some situations where
multiple networks exist.

This is not well tested at present, to do a proper job some
more network related operations need to be added so the
tests can do real operations.

https://codereview.appspot.com/56670043/

R=natefinch

115. By Martin Packman on 2014-01-20

[r=gz] Add support for network listing api call

Lists networks using the os-networks extension, which may backend
onto either neutron or nova-network. This should provide a baseline
of support even where the neutron api is not available.

Goose doesn't yet support detecting if a given extension is supported,
that would be nice here as we'll want to know which of neutron,
os-networks, and os-tenant-networks are usable.

https://codereview.appspot.com/50630044/

R=dimitern

114. By Ian Booth on 2013-12-23

[r=wallyworld] The nova service test double was incorrectly ignoring the default security group when starting an instance. It assumed that the default group did not need to be in the list of groups specified when starting, but this is not the case.

113. By Dave Cheney on 2013-11-26

[r=dave-cheney],[bug=1254564] Split out implementation specific behaviour

Use conditional compilation rather than switching on runtime.Compiler. When the upstream bugs are resolved, we can remove these hacks.

112. By Dave Cheney on 2013-11-26

[r=dave-cheney],[bug=1250253],[bug=1254564] Fix assignment to private struct member

This was detected by the Go 1.2 compiler, but is an issue regardless of compiler or revision. The core problem was assignment to a private struct member in a different package.

https://codereview.appspot.com/31890043/

111. By Michael Hudson-Doyle on 2013-11-26

[r=dave-cheney],[bug=1254564] The currentServiceMethodName changes are foul, but this branch passes all tests with gccgo. You'll need the nil-related changes to have goose work with go 1.2.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:goose
This branch contains Public information 
Everyone can see this information.

Subscribers