juju openstack environments have no security

Essentially, we don't set a Cidr, so openstack is picking 0.0.0.0/0 by default, and we failed to set the group_id (and possibly parent_group_id). To be fair, it isn't actually documented in their API docs (that I can find)
http://docs.openstack.org/api/openstack-network/2.0/content/POST_createSecGroupRule__security-group-rules_.html
http://docs.openstack.org/trunk/openstack-network/admin/content/securitygroup_api_abstractions.html

but we are passing parent_group_id and group_id in the Python implementation.

While not strictly a regression (we've built the security group this way from the beginning) it is worth back porting to the 1.14 series.

I *think* we'll need to update Goose to handle the new fields.

It looks like Goose already supported the field we wanted to use, we just needed to add it.

hi john, thanks for fixing. re to be fair comment.. to be fair.. it was a lack of testing and attention to detail that caused it not a lack of docs. ie for something that's fundamental to the security of an environment, we need to hold ourselves to a higher standard than it ran without error.. ie verify it works as expected.

It may be worth updating setUpGlobalGroup so that it *checks* the existing global group, rather than just ensureGroup. I hadn't used the openstack provider for a long time (it seems since before this was fixed), so when I just bootstrapped and deployed a service, I found all ports were already exposed.

Turns out it was because the juju-openstack secgroup already existed. Destroying the environment, manually deleting the secgroups and retrying gave the correct secgroup with the groupid set as per the fix.