Code review comment for lp:~gz/goamz/example_dns

Reviewers: mp+179717_code.launchpad.net,

Message:
Please take a look.

Description:
Use testing.invalid rather than example.com

Stop using example.com addresses in testing code, which
may accidentally be used in a real lookup. Taking the
'.invalid' option from RFC 2606 means the resolve should
always fail locally.

https://code.launchpad.net/~gz/goamz/example_dns/+merge/179717

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12765043/

Affected files:
   A [revision details]
   M ec2/ec2t_test.go
   M ec2/ec2test/server.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: ec2/ec2t_test.go
=== modified file 'ec2/ec2t_test.go'
--- ec2/ec2t_test.go 2013-01-31 17:06:10 +0000
+++ ec2/ec2t_test.go 2013-08-12 14:33:16 +0000
@@ -68,7 +68,7 @@
   })
   c.Assert(err, IsNil)
   c.Assert(inst, NotNil)
- c.Assert(inst.Instances[0].DNSName, Equals,
inst.Instances[0].InstanceId+".example.com")
+ c.Assert(inst.Instances[0].DNSName, Equals,
inst.Instances[0].InstanceId+".testing.invalid")

   id := inst.Instances[0].InstanceId

Index: ec2/ec2test/server.go
=== modified file 'ec2/ec2test/server.go'
--- ec2/ec2test/server.go 2013-01-31 17:06:10 +0000
+++ ec2/ec2test/server.go 2013-08-12 14:33:16 +0000
@@ -548,7 +548,7 @@
    InstanceId: inst.id,
    InstanceType: inst.instType,
    ImageId: inst.imageId,
- DNSName: fmt.Sprintf("%s.example.com", inst.id),
+ DNSName: fmt.Sprintf("%s.testing.invalid", inst.id),
    // TODO the rest
   }
  }