Code review comment for lp:~gz/bzr/url_unquote_unreserved_842223

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/16/2011 2:47 PM, Martin Packman wrote:
> sent to pqm by email
>

Have you tried using this with a real branch? The test was enforcing
that we preserve the existing formatting, so that users doing "bzr up"
don't get "failed-to-lock-master-branch" failures when the URL mismatches.

Certainly, we can just rewrite the test, etc.

What would be nice if we could update the matching logic to
normalize-but-preserve. So it would know that "~a" == "%7Ea", but it
would leave the URL at whatever it was when it read it.

We've flip-flopped at least once on this, and got a bunch of bug
reports both times. I really don't want us to do that again.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7Dv3oACgkQJdeBCYSNAANJjwCdGlvTASTI4Adl+qvSQZ5XtJDc
5GMAn3CzRBAqUIOiSfwy+NNFgmpQK7Hw
=6Dyl
-----END PGP SIGNATURE-----