Code review comment for lp:~gz/bzr/url_unquote_unreserved_842223

Revision history for this message
Martin Packman (gz) wrote :

> I haven't really reviewed the code, I would just be really careful
> changing how encoding works. It tends to break users because of the
> "is the branch I'm pulling from my master branch" check.

Yes, I agree it's scary, which is why I based this branch branch on a revision preceding the urlutils changes to make sure the tests would get the previous logic back correctly.

So, to clarify, the only behavioural change should be to transport.pathfilter handling, and that's a separate revision that could be backed out - if a skip was added to the tests to allow those transports using it to fail.

I'm doing a couple of runs on babune now to see what the status is.

« Back to merge proposal