Code review comment for lp:~gz/bzr/tests_for_bug_205636

Revision history for this message
Martin Pool (mbp) wrote :

> I would really like some input on:
>
> * If test_add is correct, and whether the old working tree formats should be
> fixed.
> * If anything else should be asserted in the tests, and if so what.

The tests look reasonable.

I would not bother fixing the old formats.

I would think about adding some additional assertions that the files within the directories are now versioned.

review: Approve

« Back to merge proposal