Code review comment for lp:~gz/bzr/support_OO_flag_installer

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Review: Approve
> So test this changes one needs to run following commands:
>
> make run
> python setup.py py2exe
>
> (You need to remove `build` directory before you run py2exe because it keeps a cache of py/pyo files).
>
> So, testing bzr.dev revno 5218 and this branch we have:
>
> bzr.dev:
> library.zip = 14 MB
> and entire exe folder (just bzrlib w/o tbzr and other plugins) = 19 MB
>
> This branch (with trunk changes merged):
> library.zip = 11 MB
> and entire exe folder = 17 MB
>
> The numbers from the FAR file manager, so they are not very accurate. So this branch saves about 2-3 MB.
>

Can you run 7zip to generate the LZMA compressed version of both the
pre- and post- patch versions? That will give us a view of how much the
download size will change.

I'm also curious where this will actually help, I would guess it would
be a reasonable cold-start improvement. Though if we really wanted a
change, we would set DEFLATE on the .zip file. Though that would
actually slow down *hot* performance, which isn't great. (w/ hot
performance, everything is already in mem, so adding decompression is
just overhead.)

Anyway, someone did the work, as long as it doesn't break stuff, it is
probably reasonable to use it. I guess few people try to introspect
objects from the all-in-one installer. (I use help(my_branch.foo) all
the time, but from the python interpreter.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvoKJsACgkQJdeBCYSNAAN8UQCfaQwo/2lYaB2WgTJ/BarUDssG
cQwAoM18qRZE2UBPg4JErT8+TEFty51N
=OtOv
-----END PGP SIGNATURE-----