Code review comment for lp:~gz/bzr/setlocale_on_posix_only_631350

Sorry about the summary, will try to be more coherent in future.

> This seems fine to me, but:
>
> 1) Definitely needs a NEWS entry

Sure.

> 2) Why did you move the location of the call?

As I was reindenting anyway, moving it up by the actual import (and related OSX hack) makes the script easier to follow.

> > UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-3:
> cha
> > racter maps to <undefined>
>
> I think this is separate unicode bug, maybe ls command using
> encode(xxx, errors) and therefore crashed with traceback.

Ugugugu... why is ls different to everything else? Have we got a bug number for this?

> I've just tested this build, and `bzr ls` shows russian characters
> correctly.

Alexander, did you also get a chance to test for the original issue on a pure Russian machine and check it was still present?