Code review comment for lp:~gz/bzr/non_ascii_bzr_log_312841

On Wed, Feb 01, 2012 at 01:49:33PM -0000, Martin Packman wrote:
> Martin Packman has proposed merging lp:~gz/bzr/non_ascii_bzr_log_312841 into lp:bzr/2.5 with lp:~gz/bzr/get_home_dir as a prerequisite.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> Bug #312841 in Bazaar: "UnicodeDecodeError from bzr version when log file has non-ascii path"
> https://bugs.launchpad.net/bzr/+bug/312841
>
> For more details, see:
> https://code.launchpad.net/~gz/bzr/non_ascii_bzr_log_312841/+merge/91076
>
> Fixes a UnicodeDecodeError where someone has a non-ascii home dir or sets one of the variables used to influence the location of .bzr.log to a non-ascii value. As per other changes along these, the trade off is that someone who sets BZR_LOG on a posix system to some random bytestring not in their locale will now get an error. That's a less likely scenario and can't be fixed without some bigger changes to how bzr deals with paths.

I'm sure there's a unicode symbol symbol expressing approval
somewhere, but I can't find it at the moment. For now, then:

  merge approve

Cheers,

Jelmer