Code review comment for lp:~gz/bzr/https_proxy_host_matching_944696

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This looks good. I think this needs a release notes entry.

I'm not sure what the best way is to test this either. Ideally we'd set up an actual proxy, but you mentioned on IRC that it's hard to do with twisted's servers?

review: Approve

« Back to merge proposal