Code review comment for lp:~gz/bzr/cleanup_testcases_by_collection_613247

Quick followup on some points from review last time round.

> > > Huh ? Where are my tests gone ? (Strong suspicion around your modification
> > of
> > > __iter__)
> >
> > I suspect this is related to --parallel which I thought might be affected
> but
> > didn't have any easy way of testing on my machine, I'll take another look at
> > that code.
>
> Clearly --parallel specific and at least one __iter__ you've modified should
> be involved.

This was a combination of subunit playing very differently to the normal selftest result object, and bug 625551 meaning the errors from the children were silently eaten so I didn't notice.

> I'm pretty sure the way the log formatter are registered requires that a
> single instance is used
> and you've changed that. In this case I think breaking the cycle with an
> addCleanup should be ok.

Made this change.

> I'm fine with that as long as an option control it, there are precedents, look
> for the lock checks.

I'm still avoiding this for the moment, so people with 8GB ram at least get some console spam before they completely break my box.

> Right, testing with your testtools patch, I still get ~2000 uncollected tests.

The testtools change landed for 0.9.7 and I'd be interested in a new count. Should now not break with subunit which should help.